feat!: remove Transifex calls for FC-0012 - OEP-58 #34355
Conversation
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
OmarIthawi
force-pushed
the
depr-tx
branch
3 times, most recently
from
872fccc
to
5f0de1d
Compare
|
@timmc-edx this pull request is ready. |
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
| else | ||
| pull_translations: ## pull translations via atlas | ||
| # Clean up the existing translations | ||
| git clean -fdX conf/locale conf/plugins-locale */static/js/i18n/ */static/js/xblock.v1-i18n/ |
There was a problem hiding this comment.
This line is causing some problems -- it deletes any virtualenv that's maintained inside the repo (.venv-3.8/ in my case) as well as the Open_edX.egg-info/ created when installing base requirements. The former causes the command to fail entirely, and the latter produces the following error:
RuntimeError: Model class openedx.core.djangoapps.content_libraries.models.ContentLibrary doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.
make[1]: *** [Makefile:52: pull_xblock_translations] Error 1
Can we use a different command? Or is this even needed at all. It seems to me that a git pull should remove the files just fine.
There was a problem hiding this comment.
It appears that if one of the path arguments to git clean doesn't exist and contains a globbing character (e.g. */static/js/xblock.v1-i18n/) then the command also removes some things outside of the given paths.
There was a problem hiding this comment.
@timmc-edx sorry about that. I don't fully understand why git clean is behaving like this, so I've gone and refactored the command to be more explicit and safe:
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pullandtx pushcommands.poor.mofiles will be committed into the reposMakefiletargets and configuration filespaver i18n_*obsolete commandsTODO
pull_translationsScreenshot for Arabic language without translations
pull_translationsScreenshot for Arabic with translations
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.